181 lines
8.1 KiB
TypeScript
181 lines
8.1 KiB
TypeScript
import "./setup_env";
|
||
import { test, expect, describe } from "bun:test";
|
||
import { buildHandoverMarkdown, handoverBlockReason, handoverEligible } from "../src/handover";
|
||
import { REPO_UNPUSHED } from "@bbbug/shared/repos";
|
||
import type { Task } from "../src/types";
|
||
|
||
const baseTask = (patch: Partial<Task> = {}): Task => ({
|
||
id: "task-1",
|
||
meegoId: "1",
|
||
meegoUrl: "https://meego.example/1",
|
||
title: "闪退修复",
|
||
description: "打开详情页闪退",
|
||
reproSteps: "1. 打开 App\n2. 进详情页",
|
||
platform: "android",
|
||
executionPlan: "验证详情页不再闪退",
|
||
regenContext: null,
|
||
workspacePath: null,
|
||
pinned: 0,
|
||
status: "manual_review",
|
||
priorityKey: 0,
|
||
watchers: [],
|
||
createdAt: 0,
|
||
startedAt: null,
|
||
finishedAt: null,
|
||
durationMs: null,
|
||
totalDurationMs: null,
|
||
branchName: "bugfix/fix-detail-crash",
|
||
repoKey: "tiktok-android",
|
||
mrUrl: null,
|
||
logPath: null,
|
||
evalLogPath: null,
|
||
reviewHistory: null,
|
||
...patch,
|
||
} as unknown as Task);
|
||
|
||
describe("handoverEligible", () => {
|
||
test("没有分支不给导出", () => {
|
||
expect(handoverEligible(baseTask({ branchName: null }))).toBe(false);
|
||
});
|
||
test("查过了但没找到仓库(unpushed)不给导出", () => {
|
||
expect(handoverEligible(baseTask({ repoKey: REPO_UNPUSHED }))).toBe(false);
|
||
});
|
||
test("执行中/尚未开跑的阶段不给 —— 卫星还在写同一条分支", () => {
|
||
for (const status of ["fixing", "implementing", "awaiting_fix", "pending_confirmation", "initializing"]) {
|
||
expect(handoverEligible(baseTask({ status: status as Task["status"] }))).toBe(false);
|
||
}
|
||
});
|
||
test("执行结束之后的几档都开放", () => {
|
||
// bug 的 MR待合入/流转中/已完成都是 fix_succeeded;feature 的完成态是 completed
|
||
for (const status of ["manual_review", "fix_succeeded", "completed"]) {
|
||
expect(handoverEligible(baseTask({ status: status as Task["status"] }))).toBe(true);
|
||
}
|
||
});
|
||
test("人工复核 + 有分支 + 仓库已知(或未探测)才可以导出", () => {
|
||
expect(handoverEligible(baseTask())).toBe(true);
|
||
expect(handoverEligible(baseTask({ repoKey: null }))).toBe(true);
|
||
});
|
||
});
|
||
|
||
describe("handoverBlockReason", () => {
|
||
// 两种拒绝的下一步不同(等 vs 没救),说成同一句会让人白跑一趟去查分支。
|
||
test("状态没到时,理由说的是状态,而不是分支", () => {
|
||
const reason = handoverBlockReason(baseTask({ status: "fixing" as Task["status"] }));
|
||
expect(reason).toContain("执行结束");
|
||
expect(reason).not.toContain("分支");
|
||
});
|
||
test("分支没推上去时,理由说的是分支", () => {
|
||
expect(handoverBlockReason(baseTask({ repoKey: REPO_UNPUSHED }))).toContain("代码仓");
|
||
});
|
||
test("可以导出时没有理由", () => {
|
||
expect(handoverBlockReason(baseTask())).toBeNull();
|
||
});
|
||
});
|
||
|
||
describe("buildHandoverMarkdown", () => {
|
||
test("拼出分支/仓库/需求/TestSpec/报告 —— 接着干活要看的东西都在", () => {
|
||
const md = buildHandoverMarkdown("bug", baseTask(), "## FixReport\n已定位到空指针", []);
|
||
expect(md).toContain("bugfix/fix-detail-crash");
|
||
expect(md).toContain("git fetch origin bugfix/fix-detail-crash");
|
||
expect(md).toContain("打开详情页闪退");
|
||
expect(md).toContain("验证详情页不再闪退");
|
||
expect(md).toContain("已定位到空指针");
|
||
expect(md).toContain("https://meego.example/1"); // bug 才带 Meego 链接
|
||
expect(md).toContain("# 接力:"); // 面板上的叫法,别在重构里退回 Handover
|
||
});
|
||
|
||
test("节点离线拿不到报告时不留空白,给出可读的替代说明", () => {
|
||
const md = buildHandoverMarkdown("bug", baseTask(), null, []);
|
||
expect(md).toContain("未能从执行节点获取报告");
|
||
});
|
||
|
||
test("只带最近两批 round-digest,只放执行事实不放模型自述", () => {
|
||
const rounds = [
|
||
{ round: 1, digest: { status: "FIXED", completed: true, touchedFiles: [{ path: "a.kt", edits: 2 }] } },
|
||
{ round: 2, digest: { status: null, completed: false, failedCommands: [{ command: "./gradlew test", error: "1 test failed" }] } },
|
||
{ round: 3, digest: { status: "REJECTED", completed: true, errors: ["NullPointerException"] } },
|
||
];
|
||
const md = buildHandoverMarkdown("bug", baseTask(), "报告", rounds);
|
||
expect(md).not.toContain("第 1 批"); // 只留最近两批
|
||
expect(md).toContain("第 2 批");
|
||
expect(md).toContain("./gradlew test");
|
||
expect(md).toContain("第 3 批");
|
||
expect(md).toContain("NullPointerException");
|
||
});
|
||
|
||
// 「从哪儿接着改」是文件里唯一的指令性内容,而它有一个反直觉的分岔:
|
||
// 已合入的任务,起点不是那条旧分支。这几条钉的就是这个分岔。
|
||
describe("从哪儿接着改", () => {
|
||
test("人工复核:直接 checkout 那条分支,不提新分支", () => {
|
||
const md = buildHandoverMarkdown("bug", baseTask({ status: "manual_review" as Task["status"] }), "报告", []);
|
||
expect(md).toContain("git checkout bugfix/fix-detail-crash");
|
||
expect(md).not.toContain("-followup");
|
||
});
|
||
|
||
test("已合入:改从最新基线起新分支,并说清旧分支可能已被删", () => {
|
||
const md = buildHandoverMarkdown("bug", baseTask({
|
||
status: "fix_succeeded" as Task["status"],
|
||
baseRef: "develop",
|
||
mergedIntoBaseAt: 1_700_000_000_000,
|
||
}), "报告", []);
|
||
expect(md).toContain("已经合入");
|
||
expect(md).toContain("git checkout -b bugfix/fix-detail-crash-followup origin/develop");
|
||
expect(md).toContain("被删除"); // 分支不见了是正常的,不是改动丢了
|
||
});
|
||
|
||
test("跑完但没有合入记录:两条路都给,让本地 fetch 见分晓", () => {
|
||
const md = buildHandoverMarkdown("bug", baseTask({ status: "fix_succeeded" as Task["status"] }), "报告", []);
|
||
expect(md).toContain("git checkout bugfix/fix-detail-crash"); // 分支还在的话
|
||
expect(md).toContain("-followup"); // 已经没了的话
|
||
});
|
||
|
||
test("没有 baseRef 时不编分支名,留占位让人自己填", () => {
|
||
const md = buildHandoverMarkdown("bug", baseTask({
|
||
status: "fix_succeeded" as Task["status"],
|
||
baseRef: null,
|
||
mergedIntoBaseAt: 1_700_000_000_000,
|
||
}), "报告", []);
|
||
expect(md).toContain("<你们仓库的主干分支>");
|
||
expect(md).not.toContain("origin/null");
|
||
expect(md).not.toContain("origin/undefined");
|
||
// Eddy 的起点解析会把同一个 baseBranch 回退成 BASE_BRANCH || "develop",
|
||
// 那是给机器用的 ref;给人看的命令里不能出现这个猜测。
|
||
expect(md).not.toContain("origin/" + (process.env.BASE_BRANCH || "develop"));
|
||
});
|
||
|
||
test("带上 MR 与改动过的文件,作为「这次改了什么」的入口", () => {
|
||
const md = buildHandoverMarkdown("bug", baseTask({
|
||
status: "fix_succeeded" as Task["status"],
|
||
mrUrl: "https://bits.example/mr/1",
|
||
}), "报告", [
|
||
{ round: 1, digest: { status: "FIXED", completed: true, touchedFiles: [{ path: "a.kt", edits: 2 }] } },
|
||
]);
|
||
expect(md).toContain("https://bits.example/mr/1");
|
||
expect(md).toContain("a.kt");
|
||
});
|
||
});
|
||
|
||
test("Eddy context retains review history and records the resolved baseline without changing resume rules", () => {
|
||
const commit = "a".repeat(40);
|
||
const item = baseTask({ status: "fix_succeeded" as Task["status"], baseRef: "develop", mergedIntoBaseAt: 1 });
|
||
const md = buildHandoverMarkdown("bug", item, "验收报告", [], {
|
||
resolved: { commit, branch: "develop", from: "base" },
|
||
});
|
||
expect(md).toContain("-followup origin/develop");
|
||
expect(md).toContain(commit);
|
||
expect(md).toContain("RELAY.md");
|
||
expect(md).toContain("验收报告");
|
||
});
|
||
|
||
test("有人工反馈历史时列出来,提醒本地别重蹈覆辙", () => {
|
||
const md = buildHandoverMarkdown(
|
||
"bug",
|
||
baseTask({ reviewHistory: [{ at: 1, source: "human", round: 1, text: "这个方案会导致内存泄漏,别用 static 持有 Context" }] }),
|
||
"报告",
|
||
[],
|
||
);
|
||
expect(md).toContain("内存泄漏");
|
||
expect(md).toContain("人已经反馈过什么");
|
||
});
|
||
});
|